-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ASV tests with QASM3 dump #13334
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
# This code is part of Qiskit. | ||
# | ||
# (C) Copyright IBM 2024 | ||
# | ||
# This code is licensed under the Apache License, Version 2.0. You may | ||
# obtain a copy of this license in the LICENSE.txt file in the root directory | ||
# of this source tree or at http://www.apache.org/licenses/LICENSE-2.0. | ||
# | ||
# Any modifications or derivative works of this code must retain this | ||
# copyright notice, and modified files need to carry a notice indicating | ||
# that they have been altered from the originals. | ||
|
||
# pylint: disable=missing-docstring | ||
# pylint: disable=attribute-defined-outside-init | ||
|
||
from qiskit.circuit import Parameter | ||
from qiskit import QuantumCircuit | ||
from qiskit import qasm3 | ||
|
||
from .utils import random_circuit | ||
|
||
|
||
class RandomBenchmarks: | ||
|
||
params = ([20], [256, 1024], [0, 42]) | ||
|
||
param_names = ["n_qubits", "depth", "seed"] | ||
timeout = 300 | ||
|
||
def setup(self, n_qubits, depth, seed): | ||
self.circuit = random_circuit( | ||
n_qubits, | ||
depth, | ||
measure=True, | ||
conditional=True, | ||
reset=True, | ||
seed=seed, | ||
max_operands=3, | ||
) | ||
|
||
def time_dumps(self, _, __, ___): | ||
qasm3.dumps(self.circuit) | ||
|
||
|
||
class CustomGateBenchmarks: | ||
|
||
params = ([200], [100]) | ||
|
||
param_names = ["n_qubits", "depth"] | ||
timeout = 300 | ||
|
||
def setup(self, n_qubits, depth): | ||
custom_gate = QuantumCircuit(2, name="custom_gate") | ||
custom_gate.h(0) | ||
custom_gate.x(1) | ||
|
||
qc = QuantumCircuit(n_qubits) | ||
for _ in range(depth): | ||
for i in range(n_qubits - 1): | ||
qc.append(custom_gate.to_gate(), [i, i + 1]) | ||
self.circuit = qc | ||
|
||
def time_dumps(self, _, __): | ||
qasm3.dumps(self.circuit) | ||
|
||
|
||
class ParameterizedBenchmarks: | ||
|
||
params = ([20, 50], [1, 5, 10]) | ||
|
||
param_names = ["n_qubits", "n_params"] | ||
timeout = 300 | ||
|
||
def setup(self, n_qubits, n_params): | ||
qc = QuantumCircuit(n_qubits) | ||
params = [Parameter(f"angle{i}") for i in range(n_params)] | ||
for n in range(n_qubits - 1): | ||
for i in params: | ||
qc.rx(i, n) | ||
self.circuit = qc | ||
|
||
def time_dumps(self, _, __): | ||
qasm3.dumps(self.circuit) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is clearly correct, but I think this might invalidate the results because it changes the hash of the code and asv will treat this as a new version. So I think we should fix it, but lets wait to merge this until after 1.3.0rc1 is tagged so we don't interfere with the collected data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping, 1.3.0rc1 is out.