Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gene conversion fixes #64

Merged
merged 4 commits into from
Feb 28, 2025
Merged

Gene conversion fixes #64

merged 4 commits into from
Feb 28, 2025

Conversation

katehoffshutta
Copy link
Collaborator

This PR includes several changes:

  1. In gene mapping, switch subset to left_join to preserve ordering of input list
  2. Change unit tests so that ordering of test input does not match ordering of gene_mapping, to confirm order preservation of input list
  3. Changed how we handle ensembl mapping to return columns of ensembl IDs with and without version (the version parameter is now include_no_version and is set to TRUE by default)
  4. Added an exception for the case where a user inputs ensembl IDs that are a mix of versioned and unversioned (we can figure out how to support this later if it is a use case we see people having)
  5. Added function names to stop and stdout messages

@katehoffshutta katehoffshutta merged commit 376c144 into main Feb 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant