Implement CrossFitEstimator.score
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 94.99% 95.00% +0.01%
==========================================
Files 15 15
Lines 1498 1503 +5
==========================================
+ Hits 1423 1428 +5
Misses 75 75 ☔ View full report in Codecov by Sentry. |
kklein
reviewed
Jul 21, 2024
| y, self.predict(X, is_oos, oos_method), sample_weight=sample_weight | ||
| ) | ||
| elif self._estimator_type == "regressor": | ||
| return r2_score( |
There was a problem hiding this comment.
Any particular reason why you chose R2, rather than e.g. the RMSE?
metalearners/cross_fit_estimator.py
Outdated
| ) -> float: | ||
| """Return the coefficient of determination of the prediction if the estimator is | ||
| a regressor or the mean accuracy if it is a classifier.""" | ||
| if self._estimator_type == "classifier": |
There was a problem hiding this comment.
Do you happen to know what the trade-off between doing this and using sklearn's is_classifier is here?
E.g.
There was a problem hiding this comment.
None, I just didn't think about it 😅 . I think it's better to use the sklearn methods.
108f4f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just for the sake of completeness.
Checklist
CHANGELOG.rstentry