-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CrossFitEstimator.score
#63
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ | |
|
||
import numpy as np | ||
from sklearn.base import is_classifier | ||
from sklearn.metrics import accuracy_score, r2_score | ||
from sklearn.model_selection import ( | ||
KFold, | ||
StratifiedKFold, | ||
|
@@ -337,8 +338,28 @@ | |
oos_method=oos_method, | ||
) | ||
|
||
def score(self, X, y, sample_weight=None, **kwargs): | ||
raise NotImplementedError() | ||
def score( | ||
self, | ||
X: Matrix, | ||
y: Vector, | ||
is_oos: bool, | ||
oos_method: OosMethod | None = None, | ||
sample_weight: Vector | None = None, | ||
) -> float: | ||
"""Return the coefficient of determination of the prediction if the estimator is | ||
a regressor or the mean accuracy if it is a classifier.""" | ||
if self._estimator_type == "classifier": | ||
return accuracy_score( | ||
y, self.predict(X, is_oos, oos_method), sample_weight=sample_weight | ||
) | ||
elif self._estimator_type == "regressor": | ||
return r2_score( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any particular reason why you chose R2, rather than e.g. the RMSE? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
y, self.predict(X, is_oos, oos_method), sample_weight=sample_weight | ||
) | ||
else: | ||
raise NotImplementedError( | ||
"score is not implemented for this type of estimator." | ||
) | ||
|
||
def set_params(self, **params): | ||
raise NotImplementedError() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you happen to know what the trade-off between doing this and using
sklearn
'sis_classifier
is here?E.g.
metalearners/metalearners/cross_fit_estimator.py
Line 165 in 9e00603
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None, I just didn't think about it 😅 . I think it's better to use the
sklearn
methods.108f4f3