-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename indices
to mask
. Closes issue #91
#92
Conversation
dae28f2
to
eb47b2d
Compare
Hello, I apologize for the multiple commits and any confusion this may have caused. I was working through some issues and ended up with a bit of a messy commit history. I made the mistake of forgetting to build the documentation locally, and it took several commits to rename all occurrences of the internal variable. The force-push was to amend a typo in the last commit message... embarrassing! I appreciate your understanding, and I’ll be more mindful in the future to keep things cleaner and more concise. |
Hi kklein, no problem at all regarding the changes—I'll go ahead and remove the changelog entry for version 0.12.0 as well as the files checked into docs/api. Thank you for clarifying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks a bunch! :)
Checklist
Hi, this PR changes
_treatment_variants_indices
to_treatment_variants_indices
inmetalearner.py
xlearner.py
tlearner.py
drlearner.py
test_learner.py
Closes issue #91
CHANGELOG.rst
entry