-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging for mods #445
Conversation
Regarding:
Do we still keep an indicator from where the mod is loaded from? Not saying we need to keep that message but given that with auto-download ( #362 ) we'll have a second location where we are loading mods from it would probably be useful to know still where the mod is loaded from ^^ |
Unsure, but I can always add it when the mod is loaded |
Separate mod loading into multiple functions
@F1F7Y 's PR to this branch moved things over to their own functions I have now fixed merge conflicts (which meant parsing InitScript) so I would consider this complete now I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed compiling and working in testing.
Meaningful logs will help a lot in tickets.
Good catch! |
I think i can improve on this a bit more, but think its good to be merged as is for now |
Imma try to update branch to CMake, hopefully PR survives the change ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and confirmed:
- Removes the log spam of "changing mod search path"
- [sorta] Logs mods as they are loaded, alongside their ConVars, Scripts,
ConCommands(didn't have any example, someone gimme one please <3), etc. - Warns in the console about errors in the mod.json instead of silently skipping things
Honestly, if other contributors/modders want this fine by me. Some stuff is nice, kinda indifferent about the rest.
just merge it istg |
mod.json
instead of silently skipping things