Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for mods #445

Merged
merged 51 commits into from
Jul 7, 2023
Merged

Improve logging for mods #445

Show file tree
Hide file tree
Changes from 49 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
059c82e
remove "changing mod search path" logging
ASpoonPlaysGames Apr 7, 2023
8e57712
log loading mods
ASpoonPlaysGames Apr 7, 2023
75b6a1d
use label for checking ConVars field presence
ASpoonPlaysGames Apr 7, 2023
e130063
use label for checking if ConVars field is an array
ASpoonPlaysGames Apr 7, 2023
e76decd
add warning for non-array ConVars field
ASpoonPlaysGames Apr 7, 2023
f21684c
add warnings for malformed ConVar json
ASpoonPlaysGames Apr 7, 2023
82c43fc
log sucessfully registering a ConVar for a mod
ASpoonPlaysGames Apr 7, 2023
72395ca
fix label indentation
ASpoonPlaysGames Apr 7, 2023
a637acd
use label for malformed ConCommands field
ASpoonPlaysGames Apr 7, 2023
f46b38d
log malformed ConCommands field
ASpoonPlaysGames Apr 7, 2023
052ecbe
split guard clause for ConCommand json checking
ASpoonPlaysGames Apr 7, 2023
2abcbb4
log reason for skipping registering ConCommands
ASpoonPlaysGames Apr 7, 2023
4499bc0
change warning to match format of related warnings
ASpoonPlaysGames Apr 7, 2023
79aa81e
log successful registration of mod ConCommands
ASpoonPlaysGames Apr 7, 2023
4eb8161
use label for Scripts gaurd clauses
ASpoonPlaysGames Apr 7, 2023
df55c68
log malformed Scripts array
ASpoonPlaysGames Apr 7, 2023
54d1362
split guard clause
ASpoonPlaysGames Apr 7, 2023
2467d80
warn about malformed script json
ASpoonPlaysGames Apr 7, 2023
1b45c57
log malformed callbacks for scripts
ASpoonPlaysGames Apr 7, 2023
3704cc8
log successful script registrations
ASpoonPlaysGames Apr 7, 2023
800429f
reformat success logging
ASpoonPlaysGames Apr 7, 2023
bb22289
Merge branch 'main' into logging
ASpoonPlaysGames Apr 7, 2023
43afd0d
formatting
ASpoonPlaysGames Apr 7, 2023
d58a4cf
Merge branch 'logging' of https://github.com/ASpoonPlaysGames/Northst…
ASpoonPlaysGames Apr 7, 2023
81a68bb
log localisation registration and warnings
ASpoonPlaysGames Apr 8, 2023
17931ea
logging for dependency constants
ASpoonPlaysGames Apr 8, 2023
90c1ae7
logging for load results
ASpoonPlaysGames Apr 8, 2023
43f7882
more logging for dependency constants
ASpoonPlaysGames Apr 8, 2023
41fa93d
log where mods are being loaded from
ASpoonPlaysGames Apr 8, 2023
6cfe88e
follow format for mod logging
ASpoonPlaysGames Apr 8, 2023
636198a
formatting
ASpoonPlaysGames Apr 8, 2023
b8d9b47
fix build by doing path to c str
ASpoonPlaysGames Apr 8, 2023
5ac1e4d
fix build by doing path to string
ASpoonPlaysGames Apr 8, 2023
52832e5
merge
ASpoonPlaysGames Apr 8, 2023
d48fc7f
No goto + skip loading when disabled
F1F7Y Apr 14, 2023
c2e3305
Revert booboo
F1F7Y Apr 14, 2023
1f27118
fix up formatting
F1F7Y Apr 14, 2023
e709606
clang
F1F7Y Apr 15, 2023
f8bb19b
war crimes
F1F7Y Apr 15, 2023
32f1657
among
F1F7Y Apr 15, 2023
6dff8ab
us
F1F7Y Apr 15, 2023
dec5f80
Default to enabled if we dont have enabledmodsjson
F1F7Y Apr 19, 2023
19c12d2
Remove leftover from skipping disabled mods
F1F7Y Apr 19, 2023
43bee55
Merge pull request #1 from F1F7Y/testing
ASpoonPlaysGames Apr 23, 2023
a577130
Merge branch 'main' into logging
ASpoonPlaysGames Apr 23, 2023
6440880
InitScript parsing
ASpoonPlaysGames Apr 23, 2023
9cbc1ec
Merge branch 'main' into logging
ASpoonPlaysGames May 1, 2023
47b5584
Merge branch 'main' into logging
Alystrasz Jun 10, 2023
144d3c2
Merge branch 'main' into logging
GeckoEidechse Jun 23, 2023
7ea6f9d
Merge branch 'main' into logging
Alystrasz Jul 2, 2023
f90d25c
Merge branch 'main' into logging
ASpoonPlaysGames Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions NorthstarDLL/core/filesystem/filesystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ void SetNewModSearchPaths(Mod* mod)
{
if ((fs::absolute(mod->m_ModDirectory) / MOD_OVERRIDE_DIR).string().compare(sCurrentModPath))
{
NS::log::fs->info("Changing mod search path from {} to {}", sCurrentModPath, mod->m_ModDirectory.string());
GeckoEidechse marked this conversation as resolved.
Show resolved Hide resolved

AddSearchPath(
&*(*g_pFilesystem), (fs::absolute(mod->m_ModDirectory) / MOD_OVERRIDE_DIR).string().c_str(), "GAME", PATH_ADD_TO_HEAD);
sCurrentModPath = (fs::absolute(mod->m_ModDirectory) / MOD_OVERRIDE_DIR).string();
Expand Down
Loading