Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose mods remote status to Squirrel VM #684

Merged
merged 5 commits into from
Jul 4, 2024

Conversation

Alystrasz
Copy link
Contributor

@Alystrasz Alystrasz commented Mar 31, 2024

Add a Squirrel VM method to know if a given mod is remote or not (heavily inspired by NSIsModEnabled function).

Used by R2Northstar/NorthstarMods#799

Copy link
Member

@catornot catornot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and it worked when I tested with the mods pr

@catornot catornot added the READY TO MERGE This mergeable right now label Apr 25, 2024
@GeckoEidechse GeckoEidechse changed the title feat: Expose mods remote status to Squirrel VM Expose mods remote status to Squirrel VM Jul 4, 2024
@GeckoEidechse
Copy link
Member

Merging based on reviews.

@GeckoEidechse GeckoEidechse merged commit 3edcc91 into R2Northstar:main Jul 4, 2024
4 checks passed
@Alystrasz Alystrasz deleted the feat/is-mod-remote branch July 8, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants