Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide remote mods in mods display #799

Merged
merged 11 commits into from
Aug 29, 2024

Conversation

Alystrasz
Copy link
Contributor

@Alystrasz Alystrasz commented Mar 31, 2024

Hide remote mods in the in-game mods menu, so they cannot be enabled/disabled by players.

Closes #798.

How to test

  1. Join lobby;
  2. Set allow_mod_auto_download to 1 through console (allow_mod_auto_download 1);
  3. sv_cheats 1;
  4. Download mod: script NSDownloadMod("nyami.mp_brick", "1.0.2");
  5. Reload mods: reload_mods;
  6. Go back to the main screen and check the mods list.

With this branch, the mod should not appear anymore.

Screenshots

Without this

image

With this

image

Copy link
Contributor

@RoyalBlue1 RoyalBlue1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test but code looks good and the json seems to be correct as well

@EM4Volts
Copy link
Contributor

same as blue, not tested ingame but it looks fine, uwu

@GeckoEidechse GeckoEidechse added needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Jul 4, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing. I already had nyami.mp_brick downloaded via MAD. Before the PR it still showed up in mod list. With the PR nyami.mp_brick no longer shows up in the mod list.

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Aug 29, 2024
@GeckoEidechse GeckoEidechse changed the title fix: Remote mods display Hide remote mods in mods display Aug 29, 2024
@GeckoEidechse GeckoEidechse merged commit 3d278b3 into R2Northstar:main Aug 29, 2024
3 checks passed
@Alystrasz Alystrasz deleted the fix/remote-mods-display branch August 29, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remote mods appear in the mods list
4 participants