-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project: remove clang-format for good #772
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My take on this is that we should definitely have the code standard documentation merged ASAP but I disagree with with removing clang-format.
If the formatting is shit (it is), the clang-format config should be adjusted instead. Maybe we could find the settings that are close / the same as valve source engine so that comparing diffs is easier?
In fact, @F1F7Y can you make a PR with just the code standards and I'll merge it ASAP. |
My take on it is if we remove all the annoying settings from clang-format we're just left with a glorified |
To expand on it a little more when I write code I try to format it the same as the codebase. PRs having shit formatting isn't caused by the lack of auto formatting but rather by the lack of a well formatted codebase ( and written down rules :3 ). You could argue that just making clang format less strict would work, which it partially would, but I'd argue at that point it just becomes an annoyance. I don't care whether you put a space after an |
Removes clang-format and replaces it with a code standards document. Doesn't format any files.
First commit (8a4948e) is the important change.
Second commit(2f02a69) just removes all the clang-format comments.