Fix the POV button in spectator mode

[Khalmee]

Pressing the Middle Mouse Button while spectating switches POV from 3rd to 1st person, just like how it works in vanilla.

[x3Karma]

Looks good but I think it shouldn't need to be in a separate file, maybe modify cl_gamestate.nut would be fine.

[uniboi]

The button callback needs to be only registered when spectating

[Khalmee]

Registering and deregistering it would be pain, especially because all of the possible combinations of spectating/respawning/joining a game/switching players etc., so unless I manage do find proper callbacks for that I'd leave it as it is, since it only does something when spectating

[ASpoonPlaysGames]

Looks good but I think it shouldn't need to be in a separate file, maybe modify cl_gamestate.nut would be fine.

I think ideally we put it in the same file as the spectator UI? I don't see a reason why this needs to be specifically on the CLIENT vm

[ASpoonPlaysGames]

Works now in testing for me, and I did a formatting and code pass, so LGTM
(since I have commits on this PR now, another reviewer would be appreciated)

[ASpoonPlaysGames]

I think ideally we put it in the same file as the spectator UI? I don't see a reason why this needs to be specifically on the CLIENT vm

I now disagree with myself here, since this is more of a temp fix than a permanent solution (ideally we find the root cause of spec_mode not working in native) I think it would be better to not commit a vanilla file

[ghost]

I found out that this can be fixed on pure server-side, by adding 0.1s spectator replay delay while in third person spec mode
in mp/_spectator.gnut, line 167

if ( target.IsPlayer() )
{		
	try
	{
		player.SetObserverTarget( target )
		player.StartObserverMode( OBS_MODE_CHASE )
		player.SetSpecReplayDelay( 0.1 ) // at least 0.1s specReplayDelay is required for client to know that player is spectating, and they can send "spec_mode" client command
	}
	catch ( ex ) { }
}

the same file, in function ClientCommandCallback_spec_mode()

bool function ClientCommandCallback_spec_mode( entity player, array<string> args )
{
	// currently unsure how this actually gets called on client, works through console and has references in client.dll tho
	if ( player.GetObserverMode() == OBS_MODE_CHASE )
	{
		// set to first person spectate		
		player.SetSpecReplayDelay( FIRST_PERSON_SPECTATOR_DELAY )
		player.SetViewEntity( player.GetObserverTarget(), true )
		player.StartObserverMode( OBS_MODE_IN_EYE )
	}
	else if ( player.GetObserverMode() == OBS_MODE_IN_EYE )
	{	
		// set to third person spectate
		player.StartObserverMode( OBS_MODE_CHASE )
		player.SetSpecReplayDelay( 0.1 ) // at least 0.1s specReplayDelay is required for client to know that player is spectating, and they can send "spec_mode" client command
	}
	
	return true
}

[F1F7Y]

I found out that this can be fixed on pure server-side, by adding 0.1s spectator replay delay while in third person spec mode in mp/_spectator.gnut, line 167

if ( target.IsPlayer() )
{		
	try
	{
		player.SetObserverTarget( target )
		player.StartObserverMode( OBS_MODE_CHASE )
		player.SetSpecReplayDelay( 0.1 ) // at least 0.1s specReplayDelay is required for client to know that player is spectating, and they can send "spec_mode" client command
	}
	catch ( ex ) { }
}

the same file, in function ClientCommandCallback_spec_mode()

bool function ClientCommandCallback_spec_mode( entity player, array<string> args )
{
	// currently unsure how this actually gets called on client, works through console and has references in client.dll tho
	if ( player.GetObserverMode() == OBS_MODE_CHASE )
	{
		// set to first person spectate		
		player.SetSpecReplayDelay( FIRST_PERSON_SPECTATOR_DELAY )
		player.SetViewEntity( player.GetObserverTarget(), true )
		player.StartObserverMode( OBS_MODE_IN_EYE )
	}
	else if ( player.GetObserverMode() == OBS_MODE_IN_EYE )
	{	
		// set to third person spectate
		player.StartObserverMode( OBS_MODE_CHASE )
		player.SetSpecReplayDelay( 0.1 ) // at least 0.1s specReplayDelay is required for client to know that player is spectating, and they can send "spec_mode" client command
	}
	
	return true
}

Recon you could do a small Pr with these changes ?

[ASpoonPlaysGames]

Would be cool if the above suggestions get implemented.

[ASpoonPlaysGames]

@Khalmee is this PR stale?

[GeckoEidechse]

Superseded by #706

(will close once other one gets merged)