Fix spec_mode bind not working
#706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASpoonPlaysGames
added
bug
GeckoEidechse
changed the title
spec_mode bind not working
GeckoEidechse
approved these changes
Dec 17, 2023
There was a problem hiding this comment.
Confirmed working in testing (had to run 3 instances of Northstar to test this lol). The fact that it fixes it is stupid but oh well.
As for code review, the changes have comments attached to explain why the lines were added which is good and like it only adds 2 lines that aren't comments.
I could complain about the unrelated whitespace change at end of file but oh well.
GeckoEidechse
pushed a commit
that referenced
this pull request
Dec 17, 2023
Fixes `spec_mode` bind not working by adding a small spectator replay delay Co-authored-by: DBmaoha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snippet from #611 (comment)
Oh yeah add @DBmaoha as a coauthor if this gets merged please :)
replaces #611