Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aegis Rank reset functionality command for Progression #727

Merged
merged 22 commits into from
Dec 14, 2023

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Sep 29, 2023

Split from #726

Adds an extra functionality in which allows players to reset the Aegis Ranks of their Titans, for now implemented just as a console command, but implemented as a button in the Matchmaking Mixtape Menu Mod that makes use of the Frontier Defense playlists menu, eventually gonna be implemented in the Mixtape Menu PR if merged.

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick and a request, but the code looks good to me :)

@ASpoonPlaysGames ASpoonPlaysGames added the needs testing Changes from the PR still need to be tested label Sep 29, 2023
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@GeckoEidechse GeckoEidechse added the almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge label Dec 13, 2023
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing.

I used Zanieon-Matchmaking_Mixtape_Menu-1.1.1 to get into the FD menu that shows Aegis rank.

Then I ran ns_resettitanaegis 5 to reset the Aegis rank of my Legion back to 1.

@GeckoEidechse GeckoEidechse added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Dec 13, 2023
@GeckoEidechse GeckoEidechse merged commit 6d678ac into R2Northstar:main Dec 14, 2023
3 checks passed
@Zanieon Zanieon deleted the progression_aegis_reset branch December 14, 2023 16:50
@GeckoEidechse GeckoEidechse added progression Changes related to progression system and removed READY TO MERGE This mergeable right now labels Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
progression Changes related to progression system
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants