-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aegis Rank reset functionality command for Progression #727
Add Aegis Rank reset functionality command for Progression #727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick and a request, but the code looks good to me :)
Northstar.CustomServers/mod/scripts/vscripts/sh_progression.nut
Outdated
Show resolved
Hide resolved
Northstar.CustomServers/mod/scripts/vscripts/sh_progression.nut
Outdated
Show resolved
Hide resolved
Co-authored-by: Jack <[email protected]>
`GetPersistentSpawnLoadoutIndex` directly in the function is returning wrong Titan index sometimes, and will reset an unwanted Titan instead. Changing the function to recieve the Titan idex from `uiGlobal.titanSpawnLoadoutIndex` seems to work better, this method also allows calling the command from console to specify a Titan to reset that is not the current selected one.
Northstar.CustomServers/mod/scripts/vscripts/sh_utility_all.gnut
Outdated
Show resolved
Hide resolved
Northstar.CustomServers/mod/scripts/vscripts/sh_progression.nut
Outdated
Show resolved
Hide resolved
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
Co-authored-by: GeckoEidechse <[email protected]>
Co-authored-by: GeckoEidechse <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working in testing.
I used Zanieon-Matchmaking_Mixtape_Menu-1.1.1
to get into the FD menu that shows Aegis rank.
Then I ran ns_resettitanaegis 5
to reset the Aegis rank of my Legion back to 1
.
Split from #726
Adds an extra functionality in which allows players to reset the Aegis Ranks of their Titans, for now implemented just as a console command, but implemented as a button in the Matchmaking Mixtape Menu Mod that makes use of the Frontier Defense playlists menu, eventually gonna be implemented in the Mixtape Menu PR if merged.