-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete overhaul for the CTF script #830
Conversation
Looked through this here and there over the past few days with the intention of splicing out individual changes and so far was rather unsuccessful in particular cause of how many lines this touches. I'm really hesitant to merge any changes I don't fully understand so I'm trying to figure out the best way to merge this atm. Maybe we should go over the changes together in vc or something? |
I'm down for it so i can tell what the changes does yeah. |
7b3b4ec
to
01431b7
Compare
in an effort to have all related functions close to each other Part of the refactor in #830
as part of the refactoring effort in #830
as part of the refactoring effort in #830
as part of the refactoring effort in #830
as part of the refactoring effort in #830
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks and some questions, logic overall looks good though
Northstar.CustomServers/mod/scripts/vscripts/gamemodes/_gamemode_ctf.nut
Outdated
Show resolved
Hide resolved
Northstar.CustomServers/mod/scripts/vscripts/gamemodes/_gamemode_ctf.nut
Outdated
Show resolved
Hide resolved
Northstar.CustomServers/mod/scripts/vscripts/gamemodes/_gamemode_ctf.nut
Outdated
Show resolved
Hide resolved
Northstar.CustomServers/mod/scripts/vscripts/gamemodes/_gamemode_ctf.nut
Show resolved
Hide resolved
Northstar.CustomServers/mod/scripts/vscripts/gamemodes/_gamemode_ctf.nut
Show resolved
Hide resolved
…de_ctf.nut Co-authored-by: Jack <[email protected]>
…de_ctf.nut Co-authored-by: Jack <[email protected]>
…de_ctf.nut Co-authored-by: Jack <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working in testing when playing a few matches with @ASpoonPlaysGames @RoyalBlue1 @Alystrasz @eve-v0
Aight, we spliced out as much as possible. For the last remaining changes, we decided in VC to merge it altogether and fix any remaining bugs post merge. |
This PR is required for #829 to compile check properly, so imma already do it as well.
Yes yes @GeckoEidechse i know you hate me dumping all changes in one go, but i actually reordered some funcions and nested them with the ASCII art titles as i usually do, that means the diff will always be huge cuz github dumb to know code was reordered.