Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfucked Spawns Definitive Edition (featuring Dante from the Devil May Cry™ series) #829

Merged
merged 12 commits into from
Sep 7, 2024

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Aug 2, 2024

This is it people! This PR overhauls the entire spawn script logic to basically use only native code now, squirrel plays only a refining role in this.

I haven't tested every possible game mode and some of them might even break if this gets merged right away, so i'll probably have to make PRs for those modes as well as it goes.

@Zanieon Zanieon added needs testing Changes from the PR still need to be tested feedback wanted Feedback is wanted whether the changes by this PR are desired almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge depends on another PR Blocked until the PR it depends on is merged labels Aug 2, 2024
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently failing compile due to depending on #830

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code generally looks good to me

@Zanieon Zanieon removed the depends on another PR Blocked until the PR it depends on is merged label Sep 2, 2024
GeckoEidechse pushed a commit that referenced this pull request Sep 2, 2024
…861)

Function is not necessary anymore, the reworked spawning logic at #829 uses playlistvars to control spawnzones creation on minimap.
@GeckoEidechse GeckoEidechse self-assigned this Sep 3, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing with Attrition on Eden and CTF on Glitch and Angel City.

No issues experienced whatsoever, so this should be good to merge :D

@GeckoEidechse GeckoEidechse merged commit 6b839de into R2Northstar:main Sep 7, 2024
3 checks passed
@Zanieon Zanieon deleted the spawnunfug2 branch September 7, 2024 20:11
@GeckoEidechse GeckoEidechse removed their assignment Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge feedback wanted Feedback is wanted whether the changes by this PR are desired needs testing Changes from the PR still need to be tested
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants