Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SetShouldCreateMinimapSpawnZones() from _gamemode_ps.nut #861

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Sep 2, 2024

Function is not necessary anymore, the reworked spawning logic at #829 uses playlistvars to control spawnzones creation on minimap.

@GeckoEidechse GeckoEidechse changed the title Remove SetShouldCreateMinimapSpawnZones() from _gamemode_ps.nut Remove SetShouldCreateMinimapSpawnZones() from _gamemode_ps.nut Sep 2, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @Zanieon we already use playlistvars on main to create the spawn zones on minimap so removing this should not have any effect, even without #829 ^^

@GeckoEidechse GeckoEidechse merged commit 23abddd into R2Northstar:main Sep 2, 2024
4 checks passed
@GeckoEidechse
Copy link
Member

GeckoEidechse commented Sep 2, 2024

Nevermind this should've been part of #829 as without it it won't draw the spawnzones on minimap (but still do spawns ofc). Oh well, you live and you learn ^^"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants