Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder code of _gamestate_mp.nut #875

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Sep 9, 2024

This is a mere code reordering of some functions in the script and labeled portions of the code under my typical the ASCII art blocks.

This is for preparation of my real code changes that will happen in future PRs.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 9, 2024
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Sep 9, 2024
@Zanieon Zanieon removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Sep 9, 2024
@Zanieon
Copy link
Contributor Author

Zanieon commented Sep 9, 2024

To test this PR, just simply open the game, and check if there's no compile errors, because all functions are still exactly the same, just moved them around in the script.

@Alystrasz Alystrasz self-requested a review September 10, 2024 11:36
@GeckoEidechse GeckoEidechse self-assigned this Sep 10, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually reproduced the changes locally and confirmed that this only does re-ordering of functions (and removal of a few smaller leftover comments here and there.
There's no changes logic or formatting within the functions.

As such no testing should be necessary.

@GeckoEidechse GeckoEidechse merged commit 3dfd209 into R2Northstar:main Sep 10, 2024
3 checks passed
@Alystrasz Alystrasz removed their request for review September 10, 2024 14:55
@Zanieon Zanieon deleted the gamestate_mp_reordering branch September 10, 2024 19:28
@GeckoEidechse GeckoEidechse removed their assignment Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants