-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Interactive Marker Control & Fixed Lint Issues #1065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamjunyeong Your base branch is weird. You need to update the main branch, which is your base, using the “git pull” command as shown below.
git pull origin main
Signed-off-by: Wonho Yun <[email protected]>
958008f
to
8a28a5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that it moves well with the interactive marker. Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Description
This PR ports the TurtleBot3 Interactive Marker node to ROS2 Humble, enabling real-time control of TurtleBot3 within RViz using interactive markers. This update refines the marker-based movement system to provide a more intuitive and predictable control experience by ensuring linear and angular motions are properly separated.
Additionally, existing lint issues have been resolved, improving code maintainability and aligning with ROS2 best practices.
Summary of Changes
Refined movement control for better usability
cmd_vel.linear.x
).cmd_vel.angular.z
).Ensured rotation marker remains fixed to
base_link
base_link
, allowing users to rotate the robot easily without affecting its position.Fixed existing linting issues
Motivation
The original interactive marker control had several usability issues, including unintended linear movement while rotating and a floating rotation marker, which made precise control difficult.
This update significantly improves the user experience by:
base_link
, ensuring a stable and intuitive control scheme.Additionally, resolving linting issues improves code clarity and maintainability, making future contributions easier.
Testing & Validation
base_link
.