Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-376] Include slugs in admission requirements data and allow the use of custom admission requirements #15

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Jul 12, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-376

What is the new behavior (if this is a feature change)?
Slugs are included in admission requirements data, also allowed the use of custom admission requirements(to filter it by slugs)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

Copy link
Collaborator

@amiut amiut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.
In general I'm not sure if it's OK in terms of DDD to include WP-related terminology (slug in this case) in Domain layer, but I have no hard opinion tbh.

Copy link
Collaborator

@shvlv shvlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As we have link text and link URL, I think slug is pretty okay for our AdmissionRequirement value object.

@zhyian zhyian merged commit d83e8ea into dev Jul 16, 2024
8 checks passed
@zhyian zhyian deleted the FAU-376 branch July 16, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants