-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAU-434] Include campo keys from all related terms to degree program data #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! Code-wise LGTM. 💪🏽
Please forgive the silly question, but since we change the schema, does this require migration of existing data?
Thanks for the question. I believe all that we need it's just to invalidate cache on the providing website. |
I think we need to update again the changes made in this PR RRZE-Webteam/FAU-Studium#144, now that the campo keys format is updated, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-434
If a degree program has multiple terms with different campo keys, we only pass the keys from the last term(code).
if the specified campo keys don't match any terms, the
tax_query
is omitted entirely, causing the query to return all posts, which is unintended.What is the new behavior (if this is a feature change)?
tax_query
, we now pass 0 as required term ID, which ensures no posts are returned, as there is no term with ID 0.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
RRZE-Webteam/FAU-Studium-Embed#42