[FAU-434] Correctly assign campo keys to multiple terms within degree program #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tyrann0us
reviewed
Sep 4, 2024
|
Psalm errors are occurring because the related PR (RRZE-Webteam/FAU-Studium-Common#17) in the common package hasn't been merged into the dev branch yet. |
tyrann0us
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Psalm errors are occurring because the related PR (RRZE-Webteam/FAU-Studium-Common#17) in the common package hasn't been merged into the dev branch yet.
I also thought of that but didn't realize that was indeed the case. Sorry for the noise!
shvlv
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-434
Currently we have only one campo key per taxonomy in the degree program data, even if degree program has a few terms with different campo keys.
What is the new behavior (if this is a feature change)?
The new logic presented in related PR, includes campo keys from all related terms to degree program data. And in this PR, we update the current implementation to handle an array of campo keys instead of a single string, as was previously done.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
RRZE-Webteam/FAU-Studium-Common#17