[FAU-443, FAU-444] Make “German language skills for international students” taxonomy hierarchical #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for international students' filter and column, if exists
o-samaras
approved these changes
Dec 19, 2024
amiut
approved these changes
Dec 19, 2024
3 tasks
o-samaras
reviewed
Dec 24, 2024
| return new self( | ||
| $data[MultilingualLink::NAME], | ||
| $data[MultilingualLink::LINK_TEXT], | ||
| $data[MultilingualLink::LINK_URL], | ||
| !empty($parentData) ? self::fromArray($parentData) : null, |
There was a problem hiding this comment.
I think this is wrong. If $parentData is not empty, then fromArray is called again but this time you 're passing a Link object instead of an array. Apart from the type error this (calling fromArray() again) doesn't make sense to me in general, but I may be overlooking something here.
There was a problem hiding this comment.
Thanks for pointing this out! I believe this is correct since we’re passing an array as defined by the @psalm-type
FAU-Studium-Common/src/Application/Link.php
Lines 10 to 17 in f9b1698
| return new self( | ||
| $data[self::ID], | ||
| MultilingualString::fromArray($data[self::NAME]), | ||
| MultilingualString::fromArray($data[self::LINK_TEXT]), | ||
| MultilingualString::fromArray($data[self::LINK_URL]), | ||
| !empty($parentData) ? self::fromArray($parentData) : null, |
There was a problem hiding this comment.
The same:
FAU-Studium-Common/src/Domain/MultilingualLink.php
Lines 7 to 16 in f9b1698
src/Infrastructure/Repository/WordPressDatabaseDegreeProgramRepository.php
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature.
What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-443
https://inpsyde.atlassian.net/browse/FAU-444
Discussion: https://inpsyde.slack.com/archives/C045KFJ9MB5/p1734520808952019
What is the new behavior (if this is a feature change)?
German language skills for international studentstaxonomy is hierarchicalMultilingualLinkhas been extended with aparentproperty to enable proper synchronization of both child and parent terms to consuming websitesDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Related PR that incorporates the use of
parentproperty for synchronization to consuming websites: RRZE-Webteam/FAU-Studium-Embed#49