Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-418] Move TranslatedDegreeProgramController to common package #131

Merged
merged 2 commits into from
May 24, 2024

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented May 15, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactoring

What is the current behavior? (You can also link to an open issue here)
Currently TranslatedDegreeProgramController is used only on providing website, but we also need it on consuming websites for live search functionality via the REST API.

What is the new behavior (if this is a feature change)?
TranslatedDegreeProgramController is moved to common package.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
Psalm issue should be fixed after we merge this PR.

@zhyian zhyian marked this pull request as ready for review May 16, 2024 09:29
@zhyian zhyian requested review from shvlv, tyrann0us, amiut and o-samaras May 16, 2024 09:29
@amiut amiut mentioned this pull request May 21, 2024
3 tasks
@zhyian zhyian merged commit 76a0c08 into dev May 24, 2024
8 checks passed
@zhyian zhyian deleted the FAU-418 branch May 24, 2024 11:55
@tyrann0us tyrann0us mentioned this pull request May 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants