ramenctl: enable volsync for discovered apps #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using discovered apps, we check for volsync support in two places in the ramenconfig. - Under multiNamespace map, we look for volsyncSupported: true key value pair - Under volsync map, we need the key "disabled" to be set to false. Ramenctl was configuring only the volsync map but not the multiNamespace one. We have to live with both the fields for now because of backward compatibility reasons. Signed-off-by: Raghavendra Talur <[email protected]>
raghavendra-talur
force-pushed
the
rtalur-enable-volsync-in-discovered
branch
from
eb35a32 to
acfe67d
Compare
nirs
reviewed
Jan 14, 2025
| @@ -38,6 +38,7 @@ data: | |||
| disabled: $volsync_disabled | |||
| multiNamespace: | |||
| FeatureEnabled: true | |||
| volsyncSupported: true | |||
There was a problem hiding this comment.
We should really use $volsync_enabled since ramenctl enabled volsync only if the env report the "volsync" feature:
ramen:
hub: hub
clusters: [dr1, dr2]
topology: regional-dr
features:
volsync: true
For example the regional-dr.yaml have "volsync: false".
There was a problem hiding this comment.
The check in the ramen code is an AND of !volsync.disabled and multiNamespace.volsyncSupported. The multiNamespace.volsyncSupported section is an artifact of older code and I don't want to promote the use of it. We can always keep it enabled and only modify the volsync map.
nirs
approved these changes
Jan 14, 2025
raghavendra-talur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using discovered apps, we check for volsync support in two places in the ramenconfig.
Ramenctl was configuring only the volsync map but not the multiNamespace one.
We have to live with both the fields for now because of backward compatibility reasons.