Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ramenctl: enable volsync for discovered apps #1749

Merged
merged 1 commit into from
Jan 14, 2025
Merged

ramenctl: enable volsync for discovered apps #1749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ramenctl/ramenctl/resources/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ data:
disabled: $volsync_disabled
multiNamespace:
FeatureEnabled: true
volsyncSupported: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really use $volsync_enabled since ramenctl enabled volsync only if the env report the "volsync" feature:

ramen:
  hub: hub                                                                                          
  clusters: [dr1, dr2]
  topology: regional-dr
  features:
    volsync: true

For example the regional-dr.yaml have "volsync: false".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check in the ramen code is an AND of !volsync.disabled and multiNamespace.volsyncSupported. The multiNamespace.volsyncSupported section is an artifact of older code and I don't want to promote the use of it. We can always keep it enabled and only modify the volsync map.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, lets keep it simple then.

ramenOpsNamespace: ramen-ops
s3StoreProfiles:
- s3ProfileName: minio-on-$cluster1
Expand Down