Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CRAN maintainer #5724

Merged
merged 2 commits into from
Dec 8, 2023
Merged

update CRAN maintainer #5724

merged 2 commits into from
Dec 8, 2023

Conversation

jangorecki
Copy link
Member

closes #5710

@jangorecki jangorecki added this to the 1.14.9 milestone Nov 5, 2023
Copy link
Member

@TysonStanley TysonStanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My information looks correct, should be good to go

@@ -12,7 +12,8 @@ BugReports: https://github.com/Rdatatable/data.table/issues
VignetteBuilder: knitr
ByteCompile: TRUE
Authors@R: c(
person("Matt","Dowle", role=c("aut","cre"), email="[email protected]"),
person("Tyson","Barrett", role=c("aut","cre"), email="[email protected]"),
person("Matt","Dowle", role="aut", email="[email protected]"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok for going ahead on master branch with Tyson as CRAN maintainer, for next major feature release (non-patch).
Also for patch releases, I was assuming that Matt will continue doing that, until governance is decided.
did anybody email Matt about this? (I did not) Matt has to give his OK to CRAN maintainers on email, in order for this to be updated on CRAN.

Copy link
Member Author

@jangorecki jangorecki Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is merging to master.
1.14.10 branch already has that change: 1.14.8...hotfix1.14.10
so we may need to revert that change possibly.

From what you are suggesting it most likely means that Matt would have to still make 2 pkg submissions to CRAN: 1.14.10 and then 1.15.0. Because the latter one would be moving maintainership to Tyson. If Matt don't mind to make those 2 submissions then postponing this change sounds fine to me.

@jangorecki jangorecki modified the milestones: 1.14.10, 1.15.0 Dec 6, 2023
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (93296be) to head (e54b0ee).
Report is 726 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5724   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files          80       80           
  Lines       14820    14820           
=======================================
  Hits        14445    14445           
  Misses        375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
governance Project governance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update maintainer field in dsc file
4 participants