-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update CRAN maintainer #5724
Merged
Merged
update CRAN maintainer #5724
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,8 @@ BugReports: https://github.com/Rdatatable/data.table/issues | |
VignetteBuilder: knitr | ||
ByteCompile: TRUE | ||
Authors@R: c( | ||
person("Matt","Dowle", role=c("aut","cre"), email="[email protected]"), | ||
person("Tyson","Barrett", role=c("aut","cre"), email="[email protected]"), | ||
person("Matt","Dowle", role="aut", email="[email protected]"), | ||
person("Arun","Srinivasan", role="aut", email="[email protected]"), | ||
person("Jan","Gorecki", role="ctb"), | ||
person("Michael","Chirico", role="ctb"), | ||
|
@@ -60,7 +61,6 @@ Authors@R: c( | |
person("Davis","Vaughan", role="ctb"), | ||
person("Toby","Hocking", role="ctb"), | ||
person("Leonardo","Silvestri", role="ctb"), | ||
person("Tyson","Barrett", role="ctb"), | ||
person("Jim","Hester", role="ctb"), | ||
person("Anthony","Damico", role="ctb"), | ||
person("Sebastian","Freundt", role="ctb"), | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok for going ahead on master branch with Tyson as CRAN maintainer, for next major feature release (non-patch).
Also for patch releases, I was assuming that Matt will continue doing that, until governance is decided.
did anybody email Matt about this? (I did not) Matt has to give his OK to CRAN maintainers on email, in order for this to be updated on CRAN.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is merging to master.
1.14.10 branch already has that change: 1.14.8...hotfix1.14.10
so we may need to revert that change possibly.
From what you are suggesting it most likely means that Matt would have to still make 2 pkg submissions to CRAN: 1.14.10 and then 1.15.0. Because the latter one would be moving maintainership to Tyson. If Matt don't mind to make those 2 submissions then postponing this change sounds fine to me.