Comment Out Definitions of J and . to Fix Test 715 in cc() Environment
#6207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdhock
reviewed
Jun 27, 2024
| J = function(...) { | ||
| stopf("J() called outside of [.data.table. J() is only intended for use in i.") | ||
| } | ||
| # J = function(...) { |
There was a problem hiding this comment.
please add a short comment about why they are commented (what happens when cc is run?)
|
Generated via commit 98b8c06 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 12 minutes and 2 seconds Time taken to run |
tdhock
approved these changes
Jun 27, 2024
|
great thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where test 715 fails in the
cc()environment. The failure is due to theJfunction being inadvertently included in the namespace whencc()is used, which attaches the fulldata.tablenamespace, including non-exported functions.Changes Made
Jand.functions inR/data.table.Rto prevent them from being used or causing conflicts within thecc()environment.Related PR : #6198