Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Out Definitions of J and . to Fix Test 715 in cc() Environment #6207

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Comment Out Definitions of J and . to Fix Test 715 in cc() Environment #6207

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
339e6b8
commenting out j and . functions
Jun 27, 2024
98b8c06
added comment
Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions R/data.table.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2771,13 +2771,13 @@ address = function(x) .Call(Caddress, eval(substitute(x), parent.frame()))
}

# TODO(#6197): Export these.
J = function(...) {
stopf("J() called outside of [.data.table. J() is only intended for use in i.")
}
# J = function(...) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a short comment about why they are commented (what happens when cc is run?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 👍

# stopf("J() called outside of [.data.table. J() is only intended for use in i.")
# }

. = function(...) {
stopf(".() called outside of [.data.table. .() is only intended as an alias for list() inside DT[...].")
}
# . = function(...) {
# stopf(".() called outside of [.data.table. .() is only intended as an alias for list() inside DT[...].")
# }

let = function(...) `:=`(...)

Expand Down
Loading