-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor internal helpers which generate fragmented messages #6534
Conversation
Generated via commit 93cfd19 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 3 minutes and 30 seconds Time taken to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helper function duplicated_values looks ok.
I think we should remove group.desc argument, and add a new argument, called.from.measure
default FALSE.
- If TRUE then we use stopf("... arguments to measure should be uniquely named, problems: %s")
- If FALSE then we use stopf("elements of fun.list should be uniquely named, problems: %s")
or is there some better way of handling the translation issue?
I went with "just drop |
yes that is a good point that we shouldn't be adding arguments that the user can not provide |
OK, I'll merge here. If we decide to decide internally that parent is |
Noted in #6532. We should also address the
group.desc
issue, but in principle this PR could be submitted first. cc @aitap