-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning for joins on mixed time classes #6610
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6610 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 79 79
Lines 14518 14524 +6
=======================================
+ Hits 14316 14322 +6
Misses 202 202 ☔ View full report in Codecov by Sentry. |
Please also add yourself to the DESCRIPTION file. |
I actually think it would be even better to try and coerce among these classes where possible on the user's behalf, but anyway this PR is an improvement that we can always iterate on. |
#6728 touches very similar code, I would merge that one first and then re-work this to use |
Closes #6605