Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for joins on mixed time classes #6610

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

r2evans
Copy link
Contributor

@r2evans r2evans commented Nov 10, 2024

Closes #6605

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (03c647f) to head (b8c8f42).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6610   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          79       79           
  Lines       14518    14524    +6     
=======================================
+ Hits        14316    14322    +6     
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NEWS.md Outdated Show resolved Hide resolved
inst/tests/tests.Rraw Outdated Show resolved Hide resolved
@ben-schwen
Copy link
Member

Please also add yourself to the DESCRIPTION file.

@MichaelChirico MichaelChirico changed the title close #6605, joins on date/time do not warn Add warning for joins on mixed time classes Jan 17, 2025
@MichaelChirico
Copy link
Member

I actually think it would be even better to try and coerce among these classes where possible on the user's behalf, but anyway this PR is an improvement that we can always iterate on.

@MichaelChirico
Copy link
Member

#6728 touches very similar code, I would merge that one first and then re-work this to use coerce_col() as there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Joins do not warn user when using POSc and Date comparisons
3 participants