Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for joins on mixed time classes #6610

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add warning for joins on mixed time classes #6610

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f60d75b
close #6605, joins on date/time do not warn
r2evans Nov 10, 2024
85c00f3
Merge branch 'master' into fix/6605-time-join
ben-schwen Nov 14, 2024
b8c8f42
tweaks
r2evans Nov 14, 2024
27711e1
Merge branch 'master' into fix/6605-time-join
MichaelChirico Jan 17, 2025
bdf3874
Merge branch 'master' into fix/6605-time-join
MichaelChirico Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into fix/6605-time-join
  • Loading branch information
@MichaelChirico
MichaelChirico committed Jan 17, 2025
commit bdf3874ffc6c20f2c837c53c563a8ff0bddec091
4 changes: 3 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ rowwiseDT(

17. Assignment with `:=` to an S4 slot of an under-allocated data.table now works, [#6704](https://github.com/Rdatatable/data.table/issues/6704). Thanks @MichaelChirico for the report and fix.

18. Joining with incompatible column times (e.g., `Date` with `POSIXt`) now provides a clear warning, [#6605](https://github.com/Rdatatable/data.table/issues/6605). Thanks to @al-obrien for the report and @r2evans for the PR.
18. `as.data.table()` method for `data.frame`s (especially those with extended classes) is more consistent with `as.data.frame()` with respect to rention of attributes, [#5699](https://github.com/Rdatatable/data.table/issues/5699). Thanks @jangorecki for the report and fix.

19. Joining with incompatible column times (e.g., `Date` with `POSIXt`) now provides a clear warning, [#6605](https://github.com/Rdatatable/data.table/issues/6605). Thanks to @al-obrien for the report and @r2evans for the PR.

## NOTES

Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.