Added the C2H4 +O surface as a kinetic library #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
=======================================
Coverage 43.75% 43.75%
=======================================
Files 171 171
Lines 27935 27935
Branches 5454 5454
=======================================
Hits 12223 12223
Misses 14886 14886
Partials 826 826Continue to review full report at Codecov.
|
amarkpayne
reviewed
Oct 18, 2017
| @@ -71,6 +71,8 @@ Below is a list of pre-packaged kinetics library reactions in RMG: | |||
| +---------------------------------------+------------------------------------------------------------------------------------------+ | |||
| |BurkeH2O2inN2 |Comprehensive H2/O2 kinetic model in N2 atmosphere | | |||
| +---------------------------------------+------------------------------------------------------------------------------------------+ | |||
| |C2H4+O_Klipp2017 |C2H4 + O (including intersystem crossing), probably important for all C/H/O combustion | | |||
There was a problem hiding this comment.
The library is just the intersystem crossing reactions right? If so the description should be the following:
C2H4 + O intersystem crossing reactions, probably important for all C/H/O
amarkpayne
approved these changes
Oct 18, 2017
|
@mliu49, can you merge this pull request for me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the C2H4+O_Klipp2017 library to documentation.
This is a twin PR of ReactionMechanismGenerator/RMG-database#219