Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the C2H4 +O surface as a kinetic library #219

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Added the C2H4 +O surface as a kinetic library #219

merged 1 commit into from
Oct 18, 2017

Conversation

alongd
Copy link
Member

@alongd alongd commented Oct 17, 2017

This PR adds the C2H4+O_Klipp2017 kinetic library.
The reaction of atomic oxygen with ethylene is a fundamental oxidation
step in combustion. Since it involves an intersystem crossing from a
triplet surface to a singlet surface it requires special treatment.
Data taken from http://dx.doi.org/10.1016/j.proci.2016.06.053

The reaction of atomic oxygen with ethylene is a fundamental oxidation
step in combustion. Since it involves an intersystem crossing from a
triplet surface to a singlet surface it requires special treatment.
Data taken from http://dx.doi.org/10.1016/j.proci.2016.06.053
Copy link
Member

@amarkpayne amarkpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the numbers, and everything checks out. The changes to the docstring look good as well. I was able to run the minimal model using this library as well, so everything checks out. Feel free to merge when you're ready.

@amarkpayne
Copy link
Member

amarkpayne commented Oct 18, 2017

@mliu49, can you merge this pull request?
Along with its ReactionMechanismGenerator/RMG-Py#1216 twin. Thanks!

@mliu49 mliu49 merged commit cf39e80 into master Oct 18, 2017
@mliu49 mliu49 deleted the c2h4o branch October 18, 2017 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants