[WIP] Shadow Exchange V3 integration #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OoXooOx
reviewed
Jan 30, 2025
projects/shadow/tools.ts
Outdated
| name: 'exactInputSingle', | ||
| description: | ||
| 'Swap a specific amount of token A for token B, ensuring a minimum amount of token B is received. Optionally, send the output to another recipient.', | ||
| required: ['chainName', 'account', 'tokenIn', 'tokenOut', 'amountIn'], |
There was a problem hiding this comment.
You can't omit recipient, amountOutMin in required due strict mode of AI. If you want logic for optional arg use method from my code
There was a problem hiding this comment.
Be aware that if user not provide info that it will be null in your function
There was a problem hiding this comment.
thanks, updated all optional args at 7c54fa2
OoXooOx
reviewed
Jan 30, 2025
| { | ||
| name: 'slippageTolerance', | ||
| type: 'number', | ||
| description: 'Slippage tolerance in percentage (e.g., 5.0).', |
There was a problem hiding this comment.
Suggest this working logic for slippage
OoXooOx
reviewed
Jan 30, 2025
| amountA: string; | ||
| amountB: string; | ||
| tokenId?: number; | ||
| slippageTolerance?: number; |
There was a problem hiding this comment.
watch comment in tools file. This problem about optional args through all your code
There was a problem hiding this comment.
fixed, updated all optional args at 7c54fa2
OoXooOx
reviewed
Jan 30, 2025
| export interface Props { | ||
| chainName: string; | ||
| account: Address; | ||
| tokenA: Address; |
There was a problem hiding this comment.
Suggest tokenA > tokenA_Address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests are only allowed to modify files in the
/projectsdirectory.Any changes outside of this directory will be rejected automatically.
This PR is work in progress (WIP)