RHINENG-10827: unassign systems before template delete

[MichaelMraka]

Secure Coding Practices Checklist GitHub Link

• https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

• Input Validation
• Output Encoding
• Authentication and Password Management
• Session Management
• Access Control
• Cryptographic Practices
• Error Handling and Logging
• Data Protection
• Communication Security
• System Configuration
• Database Security
• File Management
• Memory Management
• General Coding Practices

[jira-linking]

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-10827

[psegedy]

when the template is not found then I think it won't be error from the query above but templateID=0 would be added to this query. Could that be a problem? I hope not
or maybe it would be gorm.ErrRecordNotFound in which case it is correct

[MichaelMraka]

I added check for templateID == 0

[psegedy]

it seems like error is always nil in this function if I didn't miss something so we might not need to return error at all, otherwise LGTM

[MichaelMraka]

it seems like error is always nil in this function if I didn't miss something so we might not need to return error at all, otherwise LGTM

Well, let's try once more... let TemplateDelete() return errors and put error handling into TemplatesMessageHandler(). This seems to be cleaner.