RHINENG-8141: improve evaluation performance

[psegedy]

Secure Coding Practices Checklist GitHub Link

• https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

• Input Validation
• Output Encoding
• Authentication and Password Management
• Session Management
• Access Control
• Cryptographic Practices
• Error Handling and Logging
• Data Protection
• Communication Security
• System Configuration
• Database Security
• File Management
• Memory Management
• General Coding Practices

[jira-linking]

Commits missing Jira IDs:
2898096
Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-8141

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 81.78439% with 49 lines in your changes missing coverage. Please review.

Project coverage is 65.09%. Comparing base (aba05cd) to head (2898096).
Report is 1 commits behind head on master.

Files	Patch %	Lines
evaluator/evaluate_advisories.go	85.55%	17 Missing and 9 partials ⚠️
evaluator/evaluate.go	72.72%	8 Missing and 4 partials ⚠️
evaluator/evaluate_packages.go	72.00%	6 Missing and 1 partial ⚠️
base/database/utils.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
+ Coverage   64.83%   65.09%   +0.25%     
==========================================
  Files         114      114              
  Lines        7798     7810      +12     
==========================================
+ Hits         5056     5084      +28     
+ Misses       2216     2203      -13     
+ Partials      526      523       -3     

Flag	Coverage Δ
unittests	65.09% <81.78%> (+0.25%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[psegedy]

@Dugowitch sorry for my mistake with the PR, please open a new one from your fork once you introduce changes. Overall, the logic looks good, there are only some minor things I want you to look at.

[psegedy]

/retest

[Dugowitch]

A new PR with the review comments resolved was created (see #1461).