RHINENG-8141: improve evaluation performance #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Referenced Jiras: |
14 tasks
psegedy
approved these changes
Aug 13, 2024
…ng, fix and add tests
- put `parseStored` and `parseReported` code into `evaluateChanges` -- separate functions are not needed - remove pointer to extendedAdvisories because it's unnecessary - edit function doc comment after changes
- move slice-to-map logic into `getAdvisoryMetadataByNames` since all uses converted the returned slice into a map - rename the function to `getAdvisoryMetadataIDs` to reflect changes - propagate changes into functions that used `getAdvisoryMetadataByNames`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1461 +/- ##
==========================================
+ Coverage 64.82% 64.97% +0.15%
==========================================
Files 114 114
Lines 7801 7804 +3
==========================================
+ Hits 5057 5071 +14
+ Misses 2217 2208 -9
+ Partials 527 525 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored in a way that all data is loaded and evaluated first. Then, all updates (and just the updates) are done in a single transaction. Furthermore, advisories are now processed like package have been.
For code review see #1457.
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist