Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-11929: return errata from db if it does not have attributes #1460

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Aug 13, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@psegedy psegedy requested a review from MichaelMraka August 13, 2024 10:15
Copy link

jira-linking bot commented Aug 13, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-11929

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.85%. Comparing base (1d94ffb) to head (9009cc3).
Report is 1 commits behind head on master.

Files Patch % Lines
manager/controllers/advisory_detail.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1460      +/-   ##
==========================================
- Coverage   64.86%   64.85%   -0.02%     
==========================================
  Files         114      114              
  Lines        7798     7801       +3     
==========================================
+ Hits         5058     5059       +1     
- Misses       2214     2215       +1     
- Partials      526      527       +1     
Flag Coverage Δ
unittests 64.85% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy merged commit 0a56574 into RedHatInsights:master Aug 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants