Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-11929: return errata from db if it does not have attributes #1460

Merged
merged 1 commit into from
Aug 13, 2024
Merged

RHINENG-11929: return errata from db if it does not have attributes #1460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions manager/controllers/advisory_detail.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,15 @@ func tryGetAdvisoryFromCache(advisoryName string) *AdvisoryDetailResponse {
return nil
}
middlewares.AdvisoryDetailCnt.WithLabelValues("hit").Inc()

emptyTime := time.Time{}
if val.Data.Attributes.PublicDate == emptyTime {
// advisory is found in cache but was inserted from yum_updates
// it is missing all attributes such as description, public_date, modified_date, etc.
// these attributes are added after the advisory is synced by vmaas-sync
// don't use the value from cache but from DB
return nil
}
return &val
}

Expand Down
Loading