Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-11685: debug only gin context request header #1464

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Aug 16, 2024

current log fails with

Unable to read entry, failed to marshal fields to JSON, json: unsupported type: func() (io.ReadCloser, error)
Failed to fire hook: failed to marshal fields to JSON, json: unsupported type: func() (io.ReadCloser, error)

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Unable to read entry, failed to marshal fields to JSON, json: unsupported type: func() (io.ReadCloser, error)Failed to fire hook: failed to marshal fields to JSON, json: unsupported type: func() (io.ReadCloser, error)
@psegedy psegedy requested a review from Dugowitch August 16, 2024 12:39
Copy link

jira-linking bot commented Aug 16, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-11685

@psegedy psegedy requested a review from MichaelMraka August 16, 2024 12:40
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.04%. Comparing base (36039a2) to head (3395e30).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1464      +/-   ##
==========================================
+ Coverage   65.00%   65.04%   +0.03%     
==========================================
  Files         114      114              
  Lines        7810     7810              
==========================================
+ Hits         5077     5080       +3     
+ Misses       2208     2205       -3     
  Partials      525      525              
Flag Coverage Δ
unittests 65.04% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy merged commit 0d17ef6 into RedHatInsights:master Aug 20, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants