Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-14351: fix candlepin API status handling #1544

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

MichaelMraka
Copy link
Collaborator

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Dec 13, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-14351

fixes
2024/12/13 12:34:43 [Recovery] 2024/12/13 - 12:34:43 panic recovered:
runtime error: invalid memory address or nil pointer dereference
/go/pkg/mod/github.com/gin-contrib/[email protected]/timeout.go:63 (0x1182204)
/go/pkg/mod/github.com/gin-gonic/[email protected]/context.go:185 (0xbdacca)
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.67%. Comparing base (e781993) to head (f555576).

Files with missing lines Patch % Lines
manager/controllers/template_systems_update.go 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1544      +/-   ##
==========================================
- Coverage   63.68%   63.67%   -0.02%     
==========================================
  Files         116      116              
  Lines        9740     9742       +2     
==========================================
  Hits         6203     6203              
- Misses       2986     2987       +1     
- Partials      551      552       +1     
Flag Coverage Δ
unittests 63.67% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelMraka MichaelMraka merged commit 69acadf into RedHatInsights:master Dec 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants