Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating queries #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updating queries #19

wants to merge 1 commit into from

Conversation

seanhatton
Copy link

@seanhatton seanhatton commented Jun 4, 2024

Added 4 new scripts and corrected tabulation and added comments to other scripts.

@ReproNim ReproNim deleted a comment from seanhatton Aug 6, 2024
Comment on lines +59 to +60

ORDER BY ?ID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ORDER BY ?ID
ORDER BY ?ID

@yarikoptic
Copy link
Member

I wonder what editor did you use ? may be we could/should add some vim/emacs modelines to make it consistent?

OPTIONAL {?measure nidm:isAbout ?federatedLabel }.
OPTIONAL {?measure nidm:hasLaterality ?laterality }.
}
ORDER BY ?ID ?softwareLabel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be sufficient to become consistent across runs? may be add more into the mix here, e.g.

Suggested change
ORDER BY ?ID ?softwareLabel
ORDER BY ?ID ?softwareLabel ?tool @federatedLabel

?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of adding a study name to differentiate the output and aid referencing sourced tools/data, is there such a label?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno... I just see above that you are selecting only select distinct ?ID ?tool ?softwareLabel ?federatedLabel ?laterality ?volume . IMHO better that to start with, get some samples from the "lake", and see then if things change when others to run the queries

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it against the ReproLake_dev and it looks a bit cleaner with tools as the second ordering:

ORDER BY ?ID ?tool ?softwareLabel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so let's add those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants