-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating queries #19
base: master
Are you sure you want to change the base?
Updating queries #19
Conversation
|
||
ORDER BY ?ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ORDER BY ?ID | |
ORDER BY ?ID |
I wonder what editor did you use ? may be we could/should add some vim/emacs modelines to make it consistent? |
OPTIONAL {?measure nidm:isAbout ?federatedLabel }. | ||
OPTIONAL {?measure nidm:hasLaterality ?laterality }. | ||
} | ||
ORDER BY ?ID ?softwareLabel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be sufficient to become consistent across runs? may be add more into the mix here, e.g.
ORDER BY ?ID ?softwareLabel | |
ORDER BY ?ID ?softwareLabel ?tool @federatedLabel |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of adding a study name to differentiate the output and aid referencing sourced tools/data, is there such a label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno... I just see above that you are selecting only select distinct ?ID ?tool ?softwareLabel ?federatedLabel ?laterality ?volume
. IMHO better that to start with, get some samples from the "lake", and see then if things change when others to run the queries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran it against the ReproLake_dev and it looks a bit cleaner with tools as the second ordering:
ORDER BY ?ID ?tool ?softwareLabel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so let's add those
Added 4 new scripts and corrected tabulation and added comments to other scripts.