Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose favicon, tos and rewards #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AngelLozan
Copy link

@AngelLozan AngelLozan commented Nov 15, 2022

Propose a favicon, and placement of Terms of Service and Rewards.

Also adds a pointer to the copy-address field.

Copy link
Owner

@RichAyotte RichAyotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! I've left a few comments but I'll take this PR as a list of suggestions for now.

</div>
</section>
<section class="section-tos"><div><a href="#"></a>Terms of Service</div></section>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOS is a good idea but let's leave it out until ready instead of leaving a stub.

<h2>Earnings</h2>
<h2><strong>What You can Earn</strong></h2>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The earnings section is currently disabled because functionality hasn't been implemented yet. I was hoping to tackle that soon.

@@ -53,12 +53,14 @@ const delegateAddress = `tz1R4PuhxUxBBZhfLJDx2nNjbr7WorAPX1oC`
background-color: $background-color;
display: inline-grid;
grid-template-columns: minmax(0, auto) minmax(0, auto);
cursor: pointer;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed, nice catch.

Comment on lines +7 to +9
<section class="section-earnings">
<h1> Current APY 5.5% </h1> <!-- This of course can be pulled from where ever. -->
</section>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to leave this out until the implementation of a function that pulls the value from a node or api so I'll keep this idea as a feature request.

Comment on lines +21 to +38

.section-earnings {
text-align: center;
margin-top: 10%;
}

h1 {
color: white;
font-size: clamp(2rem, 10vw, 4rem);

img {
display: inline-block;
vertical-align: text-bottom;
height: clamp(3rem, 15vw, 5rem);
vertical-align: middle;
}
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS margins for mobile have disappeared but I'm not quite sure what's the cause.

image

Comment on lines +16 to +20
{
rel: 'icon',
type: 'image/png',
href: 'btz.png'
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need a favicon but the one provided is difficult to see.

image

The image size is also quite large. I usually use https://realfavicongenerator.net/ to generate the favicon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants