-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
propose favicon, tos and rewards #8
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission! I've left a few comments but I'll take this PR as a list of suggestions for now.
</div> | ||
</section> | ||
<section class="section-tos"><div><a href="#"></a>Terms of Service</div></section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TOS is a good idea but let's leave it out until ready instead of leaving a stub.
<h2>Earnings</h2> | ||
<h2><strong>What You can Earn</strong></h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The earnings section is currently disabled because functionality hasn't been implemented yet. I was hoping to tackle that soon.
@@ -53,12 +53,14 @@ const delegateAddress = `tz1R4PuhxUxBBZhfLJDx2nNjbr7WorAPX1oC` | |||
background-color: $background-color; | |||
display: inline-grid; | |||
grid-template-columns: minmax(0, auto) minmax(0, auto); | |||
cursor: pointer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed, nice catch.
<section class="section-earnings"> | ||
<h1> Current APY 5.5% </h1> <!-- This of course can be pulled from where ever. --> | ||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to leave this out until the implementation of a function that pulls the value from a node or api so I'll keep this idea as a feature request.
|
||
.section-earnings { | ||
text-align: center; | ||
margin-top: 10%; | ||
} | ||
|
||
h1 { | ||
color: white; | ||
font-size: clamp(2rem, 10vw, 4rem); | ||
|
||
img { | ||
display: inline-block; | ||
vertical-align: text-bottom; | ||
height: clamp(3rem, 15vw, 5rem); | ||
vertical-align: middle; | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | ||
rel: 'icon', | ||
type: 'image/png', | ||
href: 'btz.png' | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely need a favicon but the one provided is difficult to see.
The image size is also quite large. I usually use https://realfavicongenerator.net/ to generate the favicon.
Propose a favicon, and placement of Terms of Service and Rewards.
Also adds a pointer to the copy-address field.