Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose favicon, tos and rewards #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

propose favicon, tos and rewards #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions components/section-about/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@
public during the fall of 2022.
</p>
<about-contact-links style="grid-area: links" />

</div>
</section>
<section class="section-tos"><div><a href="#"></a>Terms of Service</div></section>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOS is a good idea but let's leave it out until ready instead of leaving a stub.

</template>
<script setup lang="ts">
import aboutContactLinks from './about-contact-links'
Expand All @@ -38,6 +40,15 @@ import aboutContactLinks from './about-contact-links'
margin-bottom: 60px;
}

.section-tos {
margin-top: 20px;
margin-bottom: 60px;
align-items: center;
justify-content: center;
text-align: center;
cursor: pointer;
}

#section-about-content {
align-items: center;
display: grid;
Expand Down
2 changes: 1 addition & 1 deletion components/section-earnings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<section class="section-earnings">
<h2>Earnings</h2>
<h2><strong>What You can Earn</strong></h2>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The earnings section is currently disabled because functionality hasn't been implemented yet. I was hoping to tackle that soon.

<div class="gradient-box-border">
<form>
<label for="delegated-xtz-amount">Enter your XTZ Amount</label>
Expand Down
2 changes: 2 additions & 0 deletions components/section-home/home-description.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,14 @@ const delegateAddress = `tz1R4PuhxUxBBZhfLJDx2nNjbr7WorAPX1oC`
background-color: $background-color;
display: inline-grid;
grid-template-columns: minmax(0, auto) minmax(0, auto);
cursor: pointer;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed, nice catch.


#delegate-address {
border: 1px solid $primary-accent-color;
font-family: 'JetBrains Mono', monospace;
overflow-wrap: break-word;
padding: 15px;
cursor: pointer;
}

img {
Expand Down
22 changes: 22 additions & 0 deletions components/section-home/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,38 @@
<home-title style="grid-area: title" />
<home-description style="grid-area: description" />
</section>
<section class="section-earnings">
<h1> Current APY 5.5% </h1> <!-- This of course can be pulled from where ever. -->
</section>
Comment on lines +7 to +9
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to leave this out until the implementation of a function that pulls the value from a node or api so I'll keep this idea as a feature request.

</template>

<script setup lang="ts">
import homeTezzomboiz from './home-tezzomboiz'
import homeTitle from './home-title'
import homeDescription from './home-description'

</script>

<style lang="scss" scoped>
@import 'include-media';

.section-earnings {
text-align: center;
margin-top: 10%;
}

h1 {
color: white;
font-size: clamp(2rem, 10vw, 4rem);

img {
display: inline-block;
vertical-align: text-bottom;
height: clamp(3rem, 15vw, 5rem);
vertical-align: middle;
}
}

Comment on lines +21 to +38
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS margins for mobile have disappeared but I'm not quite sure what's the cause.

image

.section-home {
align-items: center;
display: grid;
Expand Down
10 changes: 9 additions & 1 deletion nuxt.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import pkg from './package.json'

export default defineNuxtConfig({
css: ['@/assets/styles/global.scss'],
meta: {
head: {
title: pkg.name,
meta: [
{
Expand All @@ -13,6 +13,11 @@ export default defineNuxtConfig({
},
],
link: [
{
rel: 'icon',
type: 'image/png',
href: 'btz.png'
},
Comment on lines +16 to +20
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need a favicon but the one provided is difficult to see.

image

The image size is also quite large. I usually use https://realfavicongenerator.net/ to generate the favicon.

{
href: `https://fonts.googleapis.com`,
rel: `preconnect`,
Expand All @@ -27,6 +32,9 @@ export default defineNuxtConfig({
rel: `stylesheet`,
},
],

},


ssr: false,
})
Binary file added public/btz.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/favicon.ico
View file
Open in desktop
Binary file not shown.