Fix OpenAL errors for Cinematic Audio and restore Classic Doom frame rate #982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #980 and #981. Added fix for #955.
This PR solves the following issues:
s_noSound
idCVar ands_restart
command so they can be used with OpenAL and XAudio2 without errors or crashes. Even though they support dynamic changes in session, the result is not perfect since level sound reloads are not currently triggered bys_restart
, and default "beep" sounds can remain until the next level load (and even permanently for pre-loaded sounds). Nonetheless, it works pretty well now.Tested on Windows 10, Manjaro Linux, and macOS Ventura.