Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Goalie utility function #1723

Closed
wants to merge 9 commits into from
Closed

[DRAFT] Goalie utility function #1723

wants to merge 9 commits into from

Conversation

kasohrab
Copy link
Contributor

@kasohrab kasohrab commented Jul 31, 2021

Description

Goalie tactic with utility functions for more dynamic behavior.

Associated Issue

Issue #???

Design Documents

(on clickup)

Steps to test

Test Case 1

  1. Make
  2. Run sim
  3. ???

Expected result: nothing new yet.

Sub-issues (for drafts)

  • Mockup
  • Working test
  • Better goalie behavior

Copy link
Contributor

@kfu02 kfu02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. You're on the right track, but currently it feels like you've just moved the logic of the original if-else branches into functions, which leaves some implicit in that section. The final should be more like:

if receive:
    # do receive skill
elif block:
    # do block skill
elif ...

where the interaction of utility scores ensures that the right action is performed given the situation.

rj_gameplay/rj_gameplay/tactic/goalie_tactic.py Outdated Show resolved Hide resolved
rj_gameplay/rj_gameplay/tactic/goalie_tactic.py Outdated Show resolved Hide resolved
rj_gameplay/rj_gameplay/tactic/goalie_tactic.py Outdated Show resolved Hide resolved
@kasohrab kasohrab changed the title Goalie util func [DRAFT] Goalie utility function Aug 3, 2021
@kasohrab kasohrab self-assigned this Aug 4, 2021
Base automatically changed from comp2021-merge to ros2 September 26, 2021 23:10
@kasohrab kasohrab closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants