-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[build] Remove python venv_bin filegroup
The filegroup unnecessarily couples our BUILD files to our repository rule, without the py_toolchain as an intermediary. Our goal is to use the toolchain to fully encapsulate the selected python interpreter. Previously the venv_bin had only two citations: (1) Jupyter executable lookup from a jupyter regression test. The test had no need for a subprocess; the production code that it's guarding (jupyter_bazel) imports jupyter from sys.path, it doesn't shell out. We rework the test to better match what it's guarding, and therefore can drop the venv_bin dependency. (2) Python interpreter lookup from installer regression test. The sys.executable used for testing already points to the venv python. The Rlocation lookup was vestigial, from an earlier draft that added the venv libraries with deps instead of with the toolchain.
- Loading branch information
1 parent
30baad1
commit a00a497
Showing
7 changed files
with
19 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import unittest | ||
|
||
from jupyter_core.command import list_subcommands | ||
|
||
|
||
class TestJupyterPrereqs(unittest.TestCase): | ||
"""Sanity checks that our install_prereqs was sufficient.""" | ||
|
||
def test_notebook(self): | ||
"""Ensures that `jupyter notebook` is installed (#12042). That | ||
subcommand is required by _jupyter_bazel_notebook_main when running | ||
interactively (i.e., when in non-test mode). | ||
""" | ||
self.assertIn("notebook", list_subcommands()) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters