Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use pkg-config to find libjpeg and yaml-cpp #13335

Merged
merged 1 commit into from
May 19, 2020
Merged

Do not use pkg-config to find libjpeg and yaml-cpp #13335

merged 1 commit into from
May 19, 2020

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented May 18, 2020

Relates #13309. I imagine there is some refactoring to support the general case of #13309, but this is in earlier to support #13102.


This change is Reviewable

@jamiesnape
Copy link
Contributor Author

@drake-jenkins-bot linux-focal-unprovisioned-gcc-bazel-experimental-release please

@jamiesnape
Copy link
Contributor Author

+@jwnimmer-tri for feature review.

Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: feature.

Please edit #13309 to explain the rationale / context we've talked about.

Reviewed 7 of 7 files at r1.
Reviewable status: needs at least two assigned reviewers

@jamiesnape
Copy link
Contributor Author

+@sammy-tri for platform review.

Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this situation is rather unfortunate, but here we are I guess. It looks like the failure on focal is unrelated?

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees sammy-tri(platform),jwnimmer-tri(platform)

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented May 19, 2020

It looks like the failure on focal is unrelated?

Yup, Focal continuous isn't passing yet in general. (I eyeball the diffs in error counts for PR builds vs Continuous, as my review metric.) Jamie is close to getting it working, though, as part of this PR train.

@jamiesnape jamiesnape merged commit 29e09b2 into RobotLocomotion:master May 19, 2020
@jamiesnape jamiesnape deleted the libjpeg-yaml-cpp branch May 19, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: low unused team: kitware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants