-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use pkg-config to find libjpeg and yaml-cpp #13335
Do not use pkg-config to find libjpeg and yaml-cpp #13335
Conversation
@drake-jenkins-bot linux-focal-unprovisioned-gcc-bazel-experimental-release please |
+@jwnimmer-tri for feature review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please edit #13309 to explain the rationale / context we've talked about.
Reviewed 7 of 7 files at r1.
Reviewable status: needs at least two assigned reviewers
+@sammy-tri for platform review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this situation is rather unfortunate, but here we are I guess. It looks like the failure on focal is unrelated?
Reviewed 7 of 7 files at r1.
Reviewable status: complete! all discussions resolved, LGTM from assignees sammy-tri(platform),jwnimmer-tri(platform)
Yup, Focal continuous isn't passing yet in general. (I eyeball the diffs in error counts for PR builds vs Continuous, as my review metric.) Jamie is close to getting it working, though, as part of this PR train. |
Relates #13309. I imagine there is some refactoring to support the general case of #13309, but this is in earlier to support #13102.
This change is