-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workspace: Upgrade styleguide latest commit #13804
Merged
jwnimmer-tri
merged 1 commit into
RobotLocomotion:master
from
jwnimmer-tri:new-release-styleguide
Aug 4, 2020
Merged
workspace: Upgrade styleguide latest commit #13804
jwnimmer-tri
merged 1 commit into
RobotLocomotion:master
from
jwnimmer-tri:new-release-styleguide
Aug 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
force-pushed
the
new-release-styleguide
branch
from
August 3, 2020 21:14
8ed50d7
to
4d3e43c
Compare
jwnimmer-tri
force-pushed
the
new-release-styleguide
branch
from
August 4, 2020 13:57
4d3e43c
to
02d334e
Compare
This incorporates cpplint.py changes to enable checking c-style comments.
jwnimmer-tri
force-pushed
the
new-release-styleguide
branch
from
August 4, 2020 17:44
02d334e
to
503dcd1
Compare
jwnimmer-tri
added
status: single reviewer ok
https://drake.mit.edu/reviewable.html
and removed
status: do not merge
status: do not review
labels
Aug 4, 2020
+@sherm1 for both reviews, please. |
sherm1
reviewed
Aug 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x 2 (checked the commit, trusting you on the SHA)
Reviewed 1 of 1 files at r1.
Reviewable status: complete! all discussions resolved, LGTM from assignee sherm1(platform)
Skipping irrelevant builds, forcing in now. |
thduynguyen
pushed a commit
to thduynguyen/drake
that referenced
this pull request
Aug 7, 2020
This incorporates cpplint.py changes to enable checking c-style comments.
thduynguyen
pushed a commit
to thduynguyen/drake
that referenced
this pull request
Aug 22, 2020
This incorporates cpplint.py changes to enable checking c-style comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates cpplint.py changes to enable checking c-style comments.
This change is