Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace: Upgrade styleguide latest commit #13804

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Aug 3, 2020

This incorporates cpplint.py changes to enable checking c-style comments.


This change is Reviewable

This incorporates cpplint.py changes to enable checking c-style comments.
@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review August 4, 2020 17:45
@jwnimmer-tri
Copy link
Collaborator Author

+@sherm1 for both reviews, please.

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: x 2 (checked the commit, trusting you on the SHA)

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee sherm1(platform)

@jwnimmer-tri
Copy link
Collaborator Author

Skipping irrelevant builds, forcing in now.

@jwnimmer-tri jwnimmer-tri merged commit 753f68c into RobotLocomotion:master Aug 4, 2020
@jwnimmer-tri jwnimmer-tri deleted the new-release-styleguide branch August 4, 2020 18:32
thduynguyen pushed a commit to thduynguyen/drake that referenced this pull request Aug 7, 2020
This incorporates cpplint.py changes to enable checking c-style comments.
thduynguyen pushed a commit to thduynguyen/drake that referenced this pull request Aug 22, 2020
This incorporates cpplint.py changes to enable checking c-style comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants